Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Fix default isParty logic for battlefield addEssentialMobs #6410

Conversation

TracentEden2
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR changes the default isParty to true for the battlefield function addEssentialMobs. This is needed because despite the default for addEssentialMobs being superlink = true the mobs will not superlink unless they are in the same party. Therefore, the current situation is that in some BCNMs (for example wings of fury and probably others) that use addEssentialMobs you can pull one mob at a time (which should not be possible). I do not know of any BCNMs where the mobs should not superlink, but if so these can be coded without using addEssentialMobs. I have discussed the change with @jmcmorris already and he thinks it is logical.

The PR also fixes a small related issue with Central Temenos 2nd floor where isParty is misspelled as inParty.

Steps to test these changes

Enter BCNM wings of furry and pull a Furries from the back and watch that the mobs superlink now

@TracentEden TracentEden force-pushed the change_battlefield_default_essential_mobs_isparty branch from b26904e to 671c45d Compare November 5, 2024 18:19
@zach2good zach2good merged commit 6eb4d78 into LandSandBoat:base Nov 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants